Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of senc box #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix parsing of senc box #33

wants to merge 1 commit into from

Conversation

paroga
Copy link

@paroga paroga commented Apr 30, 2023

IMHO the duplicated PrefixedArray isn't a clean solution, but I wasn't able to fix it otherwise.

@jairoxyz
Copy link

jairoxyz commented Aug 4, 2023 •
edited
Loading

Thanks, very helpful fix, which I hoped would solve parsing senc boxes in serveral test files I have but even with your fix it won't find any senc boxes. For example in this file https://github.com/Eyevinn/mp4ff/raw/master/mp4/testdata/prog_8s_enc_dashinit.mp4, which I tested with an online parser and it definitetly has senc boxes under the moof->traf boxes. Any chance you could try to parse it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paroga @jairoxyz